Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Heal command #468

Merged
merged 46 commits into from
Jun 18, 2024
Merged

Add Heal command #468

merged 46 commits into from
Jun 18, 2024

Conversation

pietrodimarco-dfinity
Copy link
Contributor

@pietrodimarco-dfinity pietrodimarco-dfinity commented Jun 7, 2024 •
edited by sasa-tomic
Loading

This introduces the heal command, designed to improve the health of the network by replacing unhealthy nodes within specified subnets.
The command traverses all nodes in the network, identifying and replacing the unhealthy in each subnet.

Users can optionally specify the argument --max-replaceable-nodes-per-sub to optimize the healing process up to max-replaceable-nodes-per-sub nodes.
If the --max-replaceable-nodes-per-sub argument is not provided, the algorithm will proceed replacing all and only the unhealthy nodes in the subnets.

@pietrodimarco-dfinity pietrodimarco-dfinity requested a review from a team as a code owner June 7, 2024 15:42
@pietrodimarco-dfinity pietrodimarco-dfinity marked this pull request as draft June 7, 2024 15:42
@pietrodimarco-dfinity pietrodimarco-dfinity changed the title Heal all subnets Add Heal Network command Jun 7, 2024
@pietrodimarco-dfinity pietrodimarco-dfinity changed the title Add Heal Network command Add Heal command Jun 11, 2024
@pietrodimarco-dfinity pietrodimarco-dfinity marked this pull request as ready for review June 11, 2024 16:22
@pietrodimarco-dfinity pietrodimarco-dfinity marked this pull request as draft June 12, 2024 07:35
@pietrodimarco-dfinity pietrodimarco-dfinity marked this pull request as ready for review June 17, 2024 16:10
sasa-tomic
sasa-tomic reviewed Jun 17, 2024
View reviewed changes
Copy link
Member

@sasa-tomic sasa-tomic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you!

rs/cli/src/main.rs Outdated Show resolved Hide resolved
rs/cli/src/main.rs Outdated Show resolved Hide resolved
rs/cli/src/runner.rs Outdated Show resolved Hide resolved
rs/decentralization/src/network.rs Outdated Show resolved Hide resolved
rs/cli/src/cli.rs Outdated Show resolved Hide resolved
rs/decentralization/src/network.rs Outdated Show resolved Hide resolved
rs/ic-management-types/src/requests.rs Outdated Show resolved Hide resolved
rs/ic-management-backend/src/endpoints/network.rs Outdated Show resolved Hide resolved
rs/decentralization/src/network.rs Outdated Show resolved Hide resolved
rs/decentralization/src/network.rs Outdated Show resolved Hide resolved
pietrodimarco-dfinity and others added 11 commits June 17, 2024 19:35
@pietrodimarco-dfinity @sasa-tomic
Update rs/cli/src/main.rs
3535c43 
Co-authored-by: Saša Tomić <[email protected]>
@pietrodimarco-dfinity @sasa-tomic
Update rs/cli/src/main.rs
c145360 
Co-authored-by: Saša Tomić <[email protected]>
@pietrodimarco-dfinity @sasa-tomic
Update rs/decentralization/src/network.rs
0326934 
Co-authored-by: Saša Tomić <[email protected]>
@pietrodimarco-dfinity @sasa-tomic
Update rs/cli/src/cli.rs
188e4f7 
Co-authored-by: Saša Tomić <[email protected]>
@pietrodimarco-dfinity @sasa-tomic
Update rs/decentralization/src/network.rs
6069436 
Co-authored-by: Saša Tomić <[email protected]>
@pietrodimarco-dfinity @sasa-tomic
Update rs/ic-management-types/src/requests.rs
b779c5c 
Co-authored-by: Saša Tomić <[email protected]>
@pietrodimarco-dfinity @sasa-tomic
Update rs/ic-management-backend/src/endpoints/network.rs
96f5ad8 
Co-authored-by: Saša Tomić <[email protected]>
@pietrodimarco-dfinity @sasa-tomic
Update rs/decentralization/src/network.rs
39eab14 
Co-authored-by: Saša Tomić <[email protected]>
@pietrodimarco-dfinity @sasa-tomic
Update rs/decentralization/src/network.rs
5a9a5d4 
Co-authored-by: Saša Tomić <[email protected]>
@pietrodimarco-dfinity
Add take max replacement unhealthy
1aa10db
@pietrodimarco-dfinity
Merge branch 'main' into heal-all-subnets
2ac4ea5
sasa-tomic
sasa-tomic approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@sasa-tomic sasa-tomic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

NikolaMilosa
NikolaMilosa approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@NikolaMilosa NikolaMilosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice job machine 🤖

rs/cli/src/runner.rs Show resolved Hide resolved
rs/cli/src/runner.rs Outdated Show resolved Hide resolved
rs/decentralization/src/network.rs Show resolved Hide resolved
rs/ic-management-backend/src/subnets.rs Outdated Show resolved Hide resolved
@pietrodimarco-dfinity pietrodimarco-dfinity merged commit 099fc6d into main Jun 18, 2024
4 checks passed
@pietrodimarco-dfinity pietrodimarco-dfinity deleted the heal-all-subnets branch June 18, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NikolaMilosa NikolaMilosa NikolaMilosa approved these changes

@sasa-tomic sasa-tomic sasa-tomic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pietrodimarco-dfinity @sasa-tomic @NikolaMilosa