Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dre): asking for update everywhere #535

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Conversation

NikolaMilosa
Copy link
Contributor

With this fix we will be able to:

  1. Automatically reject upgrades if stdin is not a tty (useful if running in docker container)
    To test this you can run:
echo "test" | dre registry
  1. Set an environment variable to skip the check (useful if running in some scripts that are still run from terminal)
    To test this you can run:
DRE_REFUSE_UPDATE=1 dre registry

@NikolaMilosa NikolaMilosa requested a review from a team as a code owner June 26, 2024 08:48
Copy link
Contributor

@DFINITYManu DFINITYManu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good but it still won't fix the problem of running on a script in a terminal breaking if an update is published.

Please let's get that fixed too.

@NikolaMilosa
Copy link
Contributor Author

If you have it wrapped in a script, you can add the environment variable and it will skip the check. Why is that not enough?

@NikolaMilosa NikolaMilosa merged commit 2faf0cb into main Jun 26, 2024
4 checks passed
@NikolaMilosa NikolaMilosa deleted the nm-fixing-upgrade branch June 26, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants