Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DRE tool command to fetch "untrusted" metrics from metrics-canister #640

Merged
merged 14 commits into from
Jul 18, 2024
Merged

Add DRE tool command to fetch "untrusted" metrics from metrics-canister #640

merged 14 commits into from
Jul 18, 2024

Conversation

pietrodimarco-dfinity
Copy link
Contributor

@pietrodimarco-dfinity pietrodimarco-dfinity commented Jul 17, 2024 •
edited
Loading

The following PR:

  1. Add dre node-metrics <START_AT_TIMESTAMP> [SUBNET_IDS]...
  2. Modify trustworthy command to

dre <auth> node-metrics --trustworthy --wallet <wallet> <START_AT_TIMESTAMP> [SUBNET_IDS]...

  1. Add docs for untrusted node metrics fetching
  2. Adapt docs for trustworthy node metrics fetching

@pietrodimarco-dfinity pietrodimarco-dfinity requested a review from a team as a code owner July 17, 2024 12:44
NikolaMilosa
NikolaMilosa approved these changes Jul 17, 2024
View reviewed changes
rs/cli/src/commands/node_metrics/mod.rs Outdated Show resolved Hide resolved
@pietrodimarco-dfinity pietrodimarco-dfinity changed the title Add DRE tool command to query node-metrics-canister Add DRE tool command to fetch "untrusted" metrics from metrics-canister Jul 17, 2024
sasa-tomic
sasa-tomic approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@sasa-tomic sasa-tomic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! TY!

@pietrodimarco-dfinity pietrodimarco-dfinity merged commit 553ef7d into main Jul 18, 2024
4 checks passed
@pietrodimarco-dfinity pietrodimarco-dfinity deleted the dre-tool-to-run-subnet-canister branch July 18, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NikolaMilosa NikolaMilosa NikolaMilosa approved these changes

@sasa-tomic sasa-tomic sasa-tomic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pietrodimarco-dfinity @sasa-tomic @NikolaMilosa @sa-github-api