Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dre): without confirmation used to run always in dry-run mode #641

Merged
merged 1 commit into from
Jul 18, 2024
Merged

fix(dre): without confirmation used to run always in dry-run mode #641

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions rs/cli/src/ic_admin.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,9 +162,9 @@ impl IcAdminWrapper {
return self._exec(cmd, opts, true).await;
}

// If --yes was not specified, ask the user if they want to proceed
// If --yes was specified, don't ask the user if they want to proceed
if !self.proceed_without_confirmation {
self._exec(cmd.clone(), opts.clone(), true).await?;
self._exec(cmd.clone(), opts.clone(), false).await?;
}

if self.proceed_without_confirmation || Confirm::new().with_prompt("Do you want to continue?").default(false).interact()? {
Expand Down
Loading