Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(qualification): adding resolving version from nns via rollout dashboard #740

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

NikolaMilosa
Copy link
Contributor

@NikolaMilosa NikolaMilosa commented Aug 16, 2024

This PR addresses a long known issue of qualifying from wrong versions.

The issue (as explained by David Derler):

The issue I’m referring to is the following.
mainnet_revisions.json is updated when the NNS is updated to version v1. This happens on day X (e.g. Monday).

  • On day X - k (say Thursday of the previous week) we, most likely already have a qualified v2
  • On day X + l (say Thursday of the week following the rollout of v1 ) we qualify another release v3.
  • On day X + m (say Monday of the following week) v2 hits the NNS.
  • After that v3 rollout starts and will hit the NNS on day X + m + 7.
    So the issue is that the qualification test runs between v1 <-> v3 as opposed to v2 <-> v3.
    The fix might be as easy as testing against the version of io67a in the mainnet_revisions.json and make sure that the qualification only runs once io76a has v2

It uses newly developed rollout dashboard.

NOTE: this only solves one issue and ensures that the version that will run on NNS (as forecasted by rollout dashboard) will be upgradable to the new version (being qualified in qualification process).

One more issue that needs tackling is the possibility of multiple different versions on the network where each subnet can be on different version when the rollout finishes. This issue will be addressed soon after this change is integrated.

@NikolaMilosa NikolaMilosa requested a review from a team as a code owner August 16, 2024 11:47
@NikolaMilosa NikolaMilosa merged commit a84a727 into main Aug 16, 2024
4 checks passed
@NikolaMilosa NikolaMilosa deleted the nm-correct-qualification-initial-version branch August 16, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants