Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: adapt tooltip text checks #549

Merged
merged 1 commit into from
Dec 10, 2024
Merged

test: adapt tooltip text checks #549

merged 1 commit into from
Dec 10, 2024

Conversation

peterpeterparker
Copy link
Member

@peterpeterparker peterpeterparker commented Dec 10, 2024

Motivation

Svelte v5 appears to add <!----> comments in the DOM when rendering deprecated slot elements. As a result, the tooltip tests that read HTML to compare text would not be compatible.

Notes

Related to PR #548.

Changes

  • Replace usage of innerHTML to compare text in the Tooltip test with textContent.

@peterpeterparker peterpeterparker requested review from a team as code owners December 10, 2024 06:56
@peterpeterparker peterpeterparker merged commit be3f9ad into main Dec 10, 2024
8 checks passed
@peterpeterparker peterpeterparker deleted the test/tooltip-text branch December 10, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants