Avoid margin when no title #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upload-artifacts@v3 -> v4
Merged
yhabib
reviewed
Jan 10, 2025
mstrasinskis
added a commit
that referenced
this pull request
Jan 10, 2025
actions/upload-artifact@v3 to v4 # Motivation Github checks fails with: `Error: This request has been automatically failed because it uses a deprecated version of `actions/upload-artifact: v3`. Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/` https://github.com/dfinity/gix-components/actions/runs/12695076227/job/35386237271?pr=558 # Changes - Update the artifact-actions to v4. # Tests - Applied same changes to a branch to test that it's green again - #558
yhabib
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
On the neuron details page, the voting power block needs to be displayed within a collapsible section. To achieve this, we can’t use the section’s title slot and must instead rely on a custom title (within the KeyValuePairInfo) placed in the section’s description block. Currently, if the title slot is left empty, an extra margin is added, which is undesirable.
Changes
Do not add the margin, when no title provided.
Tested locally against nns-dapp.
Screenshots