chore: disable ssr for showcase app #563
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dskloetd
reviewed
Jan 20, 2025
|
FYI, e2e test is failing on CI. |
|
@dskloetd did not had time to turn it back to draft, still debugging. I start thinking there is actually an issue in the implementation which become unmasked, somehow, by this change but, as I said, still debugging. Turned it into a draft. |
|
Display issue - or rendering race condition - was indeed reproducible on main and improved in ##565. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Without disabling SSR we would not be able to build the showcase case app once the component
InfiniteScrollis effectively used in the UI. This is becauseIntersectionObserveris not a known NodeJS property.Changes