Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename fromE8s to fromUlps #492

Merged
merged 3 commits into from
Dec 1, 2023
Merged

Rename fromE8s to fromUlps #492

merged 3 commits into from
Dec 1, 2023

Conversation

dskloetd
Copy link
Collaborator

@dskloetd dskloetd commented Dec 1, 2023 •
edited
Loading

Motivation

TokenAmountV2 doesn't use e8s.

Changes

Change fromE8s to fromUlps on TokenAmountV2.

Tests

Updated accordingly

Todos

  • Add entry to changelog (if necessary).
    not necessary

@dskloetd dskloetd marked this pull request as ready for review December 1, 2023 12:41
@dskloetd dskloetd enabled auto-merge (squash) December 1, 2023 12:43
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 1, 2023 •
edited
Loading

size-limit report 📦

Path Size
@dfinity/ckbtc 6.88 KB (0%)
@dfinity/cmc 1.01 KB (0%)
@dfinity/ledger-icrc 2.92 KB (0%)
@dfinity/ledger-icp 14.41 KB (0%)
@dfinity/nns 33.85 KB (0%)
@dfinity/nns-proto 76.3 KB (0%)
@dfinity/sns 15.04 KB (0%)
@dfinity/utils 4.33 KB (+0.1% 🔺)
@dfinity/ic-management 1.94 KB (0%)

lmuntaner
lmuntaner approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@lmuntaner lmuntaner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! Thanks

@dskloetd dskloetd merged commit 59181be into main Dec 1, 2023
@dskloetd dskloetd deleted the kloet/ulps branch December 1, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmuntaner lmuntaner lmuntaner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dskloetd @lmuntaner