bot: Update Candid Files #837
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pr-automation-bot-public[bot]](https://avatars.githubusercontent.com/u/59101585?s=60&v=4){kind=small}
yhabib
added a commit
that referenced
this pull request
Feb 10, 2025
# Motivation #837 is currently blocked because a new field in the `list_neurons` requests is breaking our tests. This PR unblocks it by updating the tests and exposing this new parameter. This PR addresses just the issues in the nns package. # Changes - Checkout ic at `14c8f44` - Ran `./scripts/import-candid ../ic` from ic-js root folder - Ran `./scripts/compile-idl-js` from ic-js root folder - Revert changes not related to the `nns` package - Fix `fromListNeurons` type - Exposed `neuron_subaccounts` through `listNeurons` - Updated expectations for tests based on the new API # Tests - Should pass as before # Todos - [x] Add entry to changelog (if necessary). --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
size-limit report 📦
|
yhabib
approved these changes
Feb 10, 2025
|
Closed in favor of #839 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The canisters APIs have been updated.
Changes
Tests