chore(IDX): remove docker-login (#2386)

Removing `docker-login` step across our CI as all the images we currently use and pull are in *ghcr.io*. We still use *docker.io* for Rosetta API but only for publishing images. --------- Co-authored-by: IDX GitHub Automation <IDX GitHub Automation>
dfinity · Jan 20, 2025 · f53c9f3 · f53c9f3
1 parent 13ed4b9
commit f53c9f3
Show file tree

Hide file tree

Showing 15 changed files with 1,024 additions and 1,109 deletions.
diff --git a/.github/workflows-source/ci-main.yml b/.github/workflows-source/ci-main.yml
@@ -49,13 +49,12 @@ anchors:
     container:
       <<: *image
     timeout-minutes: 30
-  docker-login: &docker-login
-    name: Login to Dockerhub
+  before-script: &before-script
+    name: Before script
+    id: before-script
     shell: bash
-    run: ./ci/scripts/docker-login.sh
-    env:
-      DOCKER_HUB_USER: ${{ vars.DOCKER_HUB_USER }}
-      DOCKER_HUB_PASSWORD_RO: ${{ secrets.DOCKER_HUB_PASSWORD_RO }}
+    run: |
+      [ -n "${NODE_NAME:-}" ] && echo "Node: $NODE_NAME"
   checkout: &checkout
     name: Checkout
     uses: actions/checkout@v4
@@ -105,7 +104,7 @@ jobs:
       RUN_ON_DIFF_ONLY: ${{ github.event_name == 'pull_request' && !contains(github.event.pull_request.labels.*.name, 'CI_ALL_BAZEL_TARGETS') }}
     steps:
       - <<: *checkout
-      - <<: *docker-login
+      - <<: *before-script
       - name: Set BAZEL_EXTRA_ARGS
         shell: bash
         run: |
@@ -163,7 +162,7 @@ jobs:
     if: ${{ contains(github.event.pull_request.labels.*.name, 'CI_BUILD_CHECK') }}
     steps:
       - <<: *checkout
-      - <<: *docker-login
+      - <<: *before-script
       - name: Run bazel build --config=check //rs/...
         id: bazel-build-config-check
         uses: ./.github/actions/bazel-test-all/
@@ -190,7 +189,6 @@ jobs:
         run: |
           echo "/usr/local/bin" >> $GITHUB_PATH
           echo "$HOME/.cargo/bin:" >> $GITHUB_PATH
-      - <<: *docker-login
       - name: Run Bazel Test Darwin x86-64
         id: bazel-test-darwin-x86-64
         uses:  ./.github/actions/bazel-test-all/
@@ -273,7 +271,7 @@ jobs:
     if: ${{ github.event_name != 'merge_group' }}
     steps:
       - <<: *checkout
-      - <<: *docker-login
+      - <<: *before-script
       - name: Run Build IC
         id: build-ic
         shell: bash

diff --git a/.github/workflows-source/release-testing.yml b/.github/workflows-source/release-testing.yml
@@ -40,13 +40,12 @@ anchors:
     uses: actions/checkout@v4
     with:
       ref: ${{ github.event.workflow_run.head_branch }}
-  docker-login: &docker-login
-    name: Login to Dockerhub
+  before-script: &before-script
+    name: Before script
+    id: before-script
     shell: bash
-    run: ./ci/scripts/docker-login.sh
-    env:
-      DOCKER_HUB_USER: ${{ vars.DOCKER_HUB_USER }}
-      DOCKER_HUB_PASSWORD_RO: ${{ secrets.DOCKER_HUB_PASSWORD_RO }}
+    run: |
+      [ -n "${NODE_NAME:-}" ] && echo "Node: $NODE_NAME"
   bazel-bep: &bazel-bep
     name: Upload bazel-bep
     # runs only if previous step succeeded or failed;
@@ -73,7 +72,7 @@ jobs:
     <<: *dind-large-setup
     steps:
       - <<: *checkout
-      - <<: *docker-login
+      - <<: *before-script
       - name: Run Bazel System Test Nightly
         id: bazel-test-all
         uses: ./.github/actions/bazel-test-all/
@@ -90,7 +89,7 @@ jobs:
     <<: *dind-large-setup
     steps:
       - <<: *checkout
-      - <<: *docker-login
+      - <<: *before-script
       - name: Run Bazel System Test Staging
         id: bazel-test-all
         uses: ./.github/actions/bazel-test-all/
@@ -108,7 +107,7 @@ jobs:
     timeout-minutes: 90
     steps:
       - <<: *checkout
-      - <<: *docker-login
+      - <<: *before-script
       - name: Run Bazel Test All
         id: bazel-test-all
         uses: ./.github/actions/bazel-test-all/
@@ -135,7 +134,7 @@ jobs:
       REPO_NAME: ${{ github.repository }}
     steps:
       - <<: *checkout
-      - <<: *docker-login
+      - <<: *before-script
       - name: Set up Python
         uses: actions/setup-python@v5
         with:
@@ -182,7 +181,7 @@ jobs:
     <<: *dind-large-setup
     steps:
       - <<: *checkout
-      - <<: *docker-login
+      - <<: *before-script
       - name: Run qualification for version ${{ matrix.version }} from the tip of the branch
         uses: ./.github/actions/bazel-test-all/
         with:

diff --git a/.github/workflows-source/schedule-daily.yml b/.github/workflows-source/schedule-daily.yml
@@ -31,13 +31,12 @@ anchors:
   checkout: &checkout
     name: Checkout
     uses: actions/checkout@v4
-  docker-login: &docker-login
-    name: Login to Dockerhub
+  before-script: &before-script
+    name: Before script
+    id: before-script
     shell: bash
-    run: ./ci/scripts/docker-login.sh
-    env:
-      DOCKER_HUB_USER: ${{ vars.DOCKER_HUB_USER }}
-      DOCKER_HUB_PASSWORD_RO: ${{ secrets.DOCKER_HUB_PASSWORD_RO }}
+    run: |
+      [ -n "${NODE_NAME:-}" ] && echo "Node: $NODE_NAME"
   bazel-bep: &bazel-bep
     name: Upload bazel-bep
     # runs only if previous step succeeded or failed;
@@ -64,7 +63,7 @@ jobs:
       labels: dind-large
     steps:
       - <<: *checkout
-      - <<: *docker-login
+      - <<: *before-script
       - name: Run Bazel Launch Bare Metal
         shell: bash
         run: |
@@ -108,7 +107,7 @@ jobs:
     timeout-minutes: 720 # 12 hours
     steps:
       - <<: *checkout
-      - <<: *docker-login
+      - <<: *before-script
       - name: Run FI Tests Nightly
         id: bazel-test-all
         uses: ./.github/actions/bazel-test-all/
@@ -127,7 +126,7 @@ jobs:
     timeout-minutes: 20
     steps:
       - <<: *checkout
-      - <<: *docker-login
+      - <<: *before-script
       - name: Run NNS Tests Nightly
         id: bazel-test-all
         uses: ./.github/actions/bazel-test-all/
@@ -146,7 +145,7 @@ jobs:
     timeout-minutes: 480
     steps:
       - <<: *checkout
-      - <<: *docker-login
+      - <<: *before-script
       - name: Set Benchmark Targets
         shell: bash
         run: |

diff --git a/.github/workflows-source/schedule-hourly.yml b/.github/workflows-source/schedule-hourly.yml
@@ -30,13 +30,12 @@ anchors:
   checkout: &checkout
     name: Checkout
     uses: actions/checkout@v4
-  docker-login: &docker-login
-    name: Login to Dockerhub
+  before-script: &before-script
+    name: Before script
+    id: before-script
     shell: bash
-    run: ./ci/scripts/docker-login.sh
-    env:
-      DOCKER_HUB_USER: ${{ vars.DOCKER_HUB_USER }}
-      DOCKER_HUB_PASSWORD_RO: ${{ secrets.DOCKER_HUB_PASSWORD_RO }}
+    run: |
+      [ -n "${NODE_NAME:-}" ] && echo "Node: $NODE_NAME"
   bazel-bep: &bazel-bep
     name: Upload bazel-bep
     # runs only if previous step succeeded or failed;
@@ -58,7 +57,7 @@ jobs:
     <<: *dind-large-setup
     steps:
       - <<: *checkout
-      - <<: *docker-login
+      - <<: *before-script
       - name: Run Bazel Build All No Cache
         uses:  ./.github/actions/bazel-test-all/
         env:
@@ -77,7 +76,7 @@ jobs:
       labels: dind-large
     steps:
       - <<: *checkout
-      - <<: *docker-login
+      - <<: *before-script
       - name: Run Bazel System Test Hourly
         id: bazel-test-all
         uses:  ./.github/actions/bazel-test-all/

diff --git a/.github/workflows/ci-main.yml b/.github/workflows/ci-main.yml
@@ -48,12 +48,11 @@ jobs:
         uses: actions/checkout@v4
         with:
           fetch-depth: ${{ github.event_name == 'pull_request' && 256 || 0 }}
-      - name: Login to Dockerhub
+      - name: Before script
+        id: before-script
         shell: bash
-        run: ./ci/scripts/docker-login.sh
-        env:
-          DOCKER_HUB_USER: ${{ vars.DOCKER_HUB_USER }}
-          DOCKER_HUB_PASSWORD_RO: ${{ secrets.DOCKER_HUB_PASSWORD_RO }}
+        run: |
+          [ -n "${NODE_NAME:-}" ] && echo "Node: $NODE_NAME"
       - name: Set BAZEL_EXTRA_ARGS
         shell: bash
         run: |
@@ -138,12 +137,11 @@ jobs:
         uses: actions/checkout@v4
         with:
           fetch-depth: ${{ github.event_name == 'pull_request' && 256 || 0 }}
-      - name: Login to Dockerhub
+      - name: Before script
+        id: before-script
         shell: bash
-        run: ./ci/scripts/docker-login.sh
-        env:
-          DOCKER_HUB_USER: ${{ vars.DOCKER_HUB_USER }}
-          DOCKER_HUB_PASSWORD_RO: ${{ secrets.DOCKER_HUB_PASSWORD_RO }}
+        run: |
+          [ -n "${NODE_NAME:-}" ] && echo "Node: $NODE_NAME"
       - name: Run bazel build --config=check //rs/...
         id: bazel-build-config-check
         uses: ./.github/actions/bazel-test-all/
@@ -183,12 +181,6 @@ jobs:
         run: |
           echo "/usr/local/bin" >> $GITHUB_PATH
           echo "$HOME/.cargo/bin:" >> $GITHUB_PATH
-      - name: Login to Dockerhub
-        shell: bash
-        run: ./ci/scripts/docker-login.sh
-        env:
-          DOCKER_HUB_USER: ${{ vars.DOCKER_HUB_USER }}
-          DOCKER_HUB_PASSWORD_RO: ${{ secrets.DOCKER_HUB_PASSWORD_RO }}
       - name: Run Bazel Test Darwin x86-64
         id: bazel-test-darwin-x86-64
         uses: ./.github/actions/bazel-test-all/
@@ -338,12 +330,11 @@ jobs:
         uses: actions/checkout@v4
         with:
           fetch-depth: ${{ github.event_name == 'pull_request' && 256 || 0 }}
-      - name: Login to Dockerhub
+      - name: Before script
+        id: before-script
         shell: bash
-        run: ./ci/scripts/docker-login.sh
-        env:
-          DOCKER_HUB_USER: ${{ vars.DOCKER_HUB_USER }}
-          DOCKER_HUB_PASSWORD_RO: ${{ secrets.DOCKER_HUB_PASSWORD_RO }}
+        run: |
+          [ -n "${NODE_NAME:-}" ] && echo "Node: $NODE_NAME"
       - name: Run Build IC
         id: build-ic
         shell: bash

diff --git a/.github/workflows/release-testing.yml b/.github/workflows/release-testing.yml
@@ -37,12 +37,11 @@ jobs:
         uses: actions/checkout@v4
         with:
           ref: ${{ github.event.workflow_run.head_branch }}
-      - name: Login to Dockerhub
+      - name: Before script
+        id: before-script
         shell: bash
-        run: ./ci/scripts/docker-login.sh
-        env:
-          DOCKER_HUB_USER: ${{ vars.DOCKER_HUB_USER }}
-          DOCKER_HUB_PASSWORD_RO: ${{ secrets.DOCKER_HUB_PASSWORD_RO }}
+        run: |
+          [ -n "${NODE_NAME:-}" ] && echo "Node: $NODE_NAME"
       - name: Run Bazel System Test Nightly
         id: bazel-test-all
         uses: ./.github/actions/bazel-test-all/
@@ -80,12 +79,11 @@ jobs:
         uses: actions/checkout@v4
         with:
           ref: ${{ github.event.workflow_run.head_branch }}
-      - name: Login to Dockerhub
+      - name: Before script
+        id: before-script
         shell: bash
-        run: ./ci/scripts/docker-login.sh
-        env:
-          DOCKER_HUB_USER: ${{ vars.DOCKER_HUB_USER }}
-          DOCKER_HUB_PASSWORD_RO: ${{ secrets.DOCKER_HUB_PASSWORD_RO }}
+        run: |
+          [ -n "${NODE_NAME:-}" ] && echo "Node: $NODE_NAME"
       - name: Run Bazel System Test Staging
         id: bazel-test-all
         uses: ./.github/actions/bazel-test-all/
@@ -123,12 +121,11 @@ jobs:
         uses: actions/checkout@v4
         with:
           ref: ${{ github.event.workflow_run.head_branch }}
-      - name: Login to Dockerhub
+      - name: Before script
+        id: before-script
         shell: bash
-        run: ./ci/scripts/docker-login.sh
-        env:
-          DOCKER_HUB_USER: ${{ vars.DOCKER_HUB_USER }}
-          DOCKER_HUB_PASSWORD_RO: ${{ secrets.DOCKER_HUB_PASSWORD_RO }}
+        run: |
+          [ -n "${NODE_NAME:-}" ] && echo "Node: $NODE_NAME"
       - name: Run Bazel Test All
         id: bazel-test-all
         uses: ./.github/actions/bazel-test-all/
@@ -175,12 +172,11 @@ jobs:
         uses: actions/checkout@v4
         with:
           ref: ${{ github.event.workflow_run.head_branch }}
-      - name: Login to Dockerhub
+      - name: Before script
+        id: before-script
         shell: bash
-        run: ./ci/scripts/docker-login.sh
-        env:
-          DOCKER_HUB_USER: ${{ vars.DOCKER_HUB_USER }}
-          DOCKER_HUB_PASSWORD_RO: ${{ secrets.DOCKER_HUB_PASSWORD_RO }}
+        run: |
+          [ -n "${NODE_NAME:-}" ] && echo "Node: $NODE_NAME"
       - name: Set up Python
         uses: actions/setup-python@v5
         with:
@@ -242,12 +238,11 @@ jobs:
         uses: actions/checkout@v4
         with:
           ref: ${{ github.event.workflow_run.head_branch }}
-      - name: Login to Dockerhub
+      - name: Before script
+        id: before-script
         shell: bash
-        run: ./ci/scripts/docker-login.sh
-        env:
-          DOCKER_HUB_USER: ${{ vars.DOCKER_HUB_USER }}
-          DOCKER_HUB_PASSWORD_RO: ${{ secrets.DOCKER_HUB_PASSWORD_RO }}
+        run: |
+          [ -n "${NODE_NAME:-}" ] && echo "Node: $NODE_NAME"
       - name: Run qualification for version ${{ matrix.version }} from the tip of the branch
         uses: ./.github/actions/bazel-test-all/
         with: