chore(sns): Remove neuron_parameters from ClaimSwapNeuronRequest in Swap
#1417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anchpop
force-pushed
the
@anchpop/remove-neuronparameters
branch
from
1e6d6a1 to
8d13250
Compare
anchpop
force-pushed
the
@anchpop/remove-neuronparameters
branch
from
8d13250 to
7cc9a2b
Compare
marko-k0
approved these changes
Sep 11, 2024
max-dfinity
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be done safely because SNS Governance is already not expecting this field. The field is deprecated and no longer needed.
The way that
neuron_parametersis removed is slightly subtle. Previously, theClaimSwapNeuronRequestwas duplicated between Swap and SNS Governance. Thenneuron_parameterswas removed from the SNS governance side. Now in this PR, they are deduplicated again (favoring the SNS Governance side).