Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(nervous-system-agent): Add pocket-ic support to ic-nervous-system-agent #1590

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

anchpop
Copy link
Contributor

@anchpop anchpop commented Sep 19, 2024

This will allow us to use ic-nervous-system-agent helper functions from within tests built on pocket-ic. This PR synergizes with #1589, which starts to use ic-nervous-system-agent types from within ic-nervous-system-integration-tests

@anchpop anchpop requested a review from a team as a code owner September 19, 2024 23:18
@anchpop anchpop changed the title refacotr(nervous-system-agent): Add pocket-ic support to ic-nervous-system-agent refactor(nervous-system-agent): Add pocket-ic support to ic-nervous-system-agent Sep 19, 2024
@anchpop anchpop added this pull request to the merge queue Sep 20, 2024
Merged via the queue into master with commit 682f021 Sep 20, 2024
25 of 26 checks passed
@anchpop anchpop deleted the @anchpop/pocketic-support-in-nervous-system-agent branch September 20, 2024 18:16
frankdavid pushed a commit that referenced this pull request Sep 25, 2024
…ystem-agent (#1590)

This will allow us to use ic-nervous-system-agent helper functions from
within tests built on pocket-ic. This PR synergizes with #1589, which
starts to use ic-nervous-system-agent types from within
ic-nervous-system-integration-tests
github-merge-queue bot pushed a commit that referenced this pull request Sep 25, 2024
…than `DeployedSns` (#1589)

Unlike `DeployedSns`, the `Sns` type has no optional fields. This means
we can remove the repetitive unwrapping in every test that deploys an
SNS. The `Sns` type also has some utility functions on it that can be
used in the integration tests once #1590 is merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants