feat(nns): Lower probability of panicking deprecated methods #1659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aterga
approved these changes
Sep 24, 2024
frankdavid
pushed a commit
that referenced
this pull request
Sep 25, 2024
Lower the probability of deprecated *_pb methods panicking to give integrators more time to migrate.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 6, 2025
The failure rate was 0.7: #1659 before we were notified about integrators needing more time to migrate. Now that they have migrated, ramping back to 0.7 again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lower the probability of deprecated *_pb methods panicking to give integrators more time to migrate.