Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix the regression in XNET #1992

Merged
merged 5 commits into from
Oct 11, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
.
rumenov committed Oct 11, 2024
commit 8fc63e4592956c7fad35a84d936caf5a8b5efe1f
14 changes: 7 additions & 7 deletions rs/http_endpoints/xnet/src/lib.rs
Original file line number Diff line number Diff line change
@@ -235,9 +235,9 @@ fn start_server(

let io = TokioIo::new(stream);
let conn = http.serve_connection(io, hyper_service);
if let Err(err) = conn.await {
warn!(logger, "failed to serve connection: {err}");
}
if let Err(err) = conn.await {
warn!(logger, "failed to serve connection: {err}");
}
}

#[cfg(not(test))]
@@ -265,10 +265,10 @@ fn start_server(
Ok(tls_stream) => {
let io = TokioIo::new(tls_stream);
let conn = http.serve_connection(io, hyper_service);
if let Err(err) = conn.await {
warn!(logger, "failed to serve connection: {err}");
metrics.closed_connections_total.inc();
}
if let Err(err) = conn.await {
warn!(logger, "failed to serve connection: {err}");
metrics.closed_connections_total.inc();
}
}
Err(err) => {
warn!(logger, "Error setting up TLS stream: {err}");