feat: Add an mr_receive_batch_latency_seconds metric
#2417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The metric tracks the latency of the `Receiver::recv()` call that `MessageRoutingImpl` makes to obtain the next batch from Consensus. On a subnet with a block rate of 2.5 blocks/s whose DSM does zero work and finishes immediately, we should consistently observe values around 400ms. If OTOH the DSM is backlogged and always takes more than 400ms to run, then the observed values should be consistently around zero (because the DSM would be consistently behind Consensus).
alin-at-dfinity
requested review from
yvonneanne,
derlerd-dfinity and
eichhorl
alin-at-dfinity
added a commit
that referenced
this pull request
Nov 7, 2024
The metric tracks the latency of the `Receiver::recv()` call that `MessageRoutingImpl` makes to obtain the next batch from Consensus. On a subnet with a block rate of 2.5 blocks/s whose DSM does zero work and finishes immediately, we should consistently observe values around 400ms. If OTOH the DSM is backlogged and always takes more than 400ms to run, then the observed values should be consistently around zero (because the DSM would be consistently behind Consensus).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The metric tracks the latency of the
Receiver::recv()call thatMessageRoutingImplmakes to obtain the next batch from Consensus.On a subnet with a block rate of 2.5 blocks/s whose DSM does zero work and finishes immediately, we should consistently observe values around 400ms. If OTOH the DSM is backlogged and always takes more than 400ms to run, then the observed values should be consistently around zero (because the DSM would be consistently behind Consensus).