refactor(nns): Refactor voting as precursor for more scalability #2528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-dfinity
force-pushed
the
msum/stable-neuron-support-C
branch
from
494f084 to
9cdf93c
Compare
max-dfinity
changed the title
max-dfinity
force-pushed
the
msum/stable-neuron-support-C
branch
2 times, most recently
from
406f631 to
d2eb45e
Compare
max-dfinity
force-pushed
the
msum/stable-neuron-support-C
branch
2 times, most recently
from
a08f2cc to
e571398
Compare
max-dfinity
force-pushed
the
msum/stable-neuron-support-C
branch
from
e571398 to
6ec99a1
Compare
jasonz-dfinity
approved these changes
Nov 13, 2024
max-dfinity
force-pushed
the
msum/stable-neuron-support-C
branch
from
8d3213d to
1832771
Compare
jasonz-dfinity
approved these changes
Nov 15, 2024
jasonz-dfinity
approved these changes
Nov 15, 2024
max-dfinity
commented
Nov 15, 2024
max-dfinity
force-pushed
the
msum/stable-neuron-support-C
branch
2 times, most recently
from
2cb808a to
886676d
Compare
max-dfinity
force-pushed
the
msum/stable-neuron-support-C
branch
from
886676d to
9828e39
Compare
|
LGTM |
DFINITYManu
pushed a commit
that referenced
this pull request
Nov 19, 2024
This refactoring creates a state machine to handle voting, which will create natural break points in the ongoing calculations that are being done. This will allow us to scale voting with following to an arbitrarily large number of neurons. [Next](#2600)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactoring creates a state machine to handle voting, which will create natural break points in the ongoing calculations that are being done. This will allow us to scale voting with following to an arbitrarily large number of neurons.
Next