-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(crypto): CRP-2596 create VetKdProtocol trait #2569
Merged
fspreiss
merged 11 commits into
master
from
franzstefan/CRP-2596-create-vetkdprotocol-trait
Nov 18, 2024
Merged
feat(crypto): CRP-2596 create VetKdProtocol trait #2569
fspreiss
merged 11 commits into
master
from
franzstefan/CRP-2596-create-vetkdprotocol-trait
Nov 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randombit
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM I left a few minor comments/suggestions
eichhorl
approved these changes
Nov 15, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 18, 2024
DFINITYManu
pushed a commit
that referenced
this pull request
Nov 19, 2024
Introduce a `VetKdProtocol` trait and implement it for `CryptoReturningOk`. The trait is designed so that underneath we can implement the cryptographic protocol specified in the π<sub>vetbls-agg2</sub> scheme specified in section 5.3 of the [vetKeys research paper](https://eprint.iacr.org/2023/616.pdf), in its _optimistic_ variant, where the meaning of optimistic is described in section 9 of the research paper. The π<sub>vetbls-agg2</sub> scheme is implemented in [ic-crypto-internal-bls12-381-vetkd](https://github.com/dfinity/ic/blob/master/rs/crypto/internal/crypto_lib/bls12_381/vetkd/src/lib.rs).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a
VetKdProtocol
trait and implement it forCryptoReturningOk
.The trait is designed so that underneath we can implement the cryptographic protocol specified in the πvetbls-agg2 scheme specified in section 5.3 of the vetKeys research paper, in its optimistic variant, where the meaning of optimistic is described in section 9 of the research paper. The πvetbls-agg2 scheme is implemented in ic-crypto-internal-bls12-381-vetkd.