Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(crypto): CRP-2596 create VetKdProtocol trait #2569

Merged
merged 11 commits into from
Nov 18, 2024

Conversation

fspreiss
Copy link
Member

@fspreiss fspreiss commented Nov 12, 2024

Introduce a VetKdProtocol trait and implement it for CryptoReturningOk.

The trait is designed so that underneath we can implement the cryptographic protocol specified in the πvetbls-agg2 scheme specified in section 5.3 of the vetKeys research paper, in its optimistic variant, where the meaning of optimistic is described in section 9 of the research paper. The πvetbls-agg2 scheme is implemented in ic-crypto-internal-bls12-381-vetkd.

@github-actions github-actions bot added the feat label Nov 12, 2024
@fspreiss fspreiss marked this pull request as ready for review November 12, 2024 13:56
@fspreiss fspreiss requested a review from a team as a code owner November 12, 2024 13:56
Copy link
Contributor

@randombit randombit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM I left a few minor comments/suggestions

rs/types/types/src/crypto/vetkd.rs Outdated Show resolved Hide resolved
rs/interfaces/src/crypto/vetkd.rs Show resolved Hide resolved
rs/interfaces/src/crypto/vetkd.rs Outdated Show resolved Hide resolved
rs/interfaces/src/crypto/vetkd.rs Show resolved Hide resolved
@fspreiss fspreiss added this pull request to the merge queue Nov 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 18, 2024
@fspreiss fspreiss enabled auto-merge November 18, 2024 08:11
@fspreiss fspreiss added this pull request to the merge queue Nov 18, 2024
Merged via the queue into master with commit e44d2bc Nov 18, 2024
25 checks passed
@fspreiss fspreiss deleted the franzstefan/CRP-2596-create-vetkdprotocol-trait branch November 18, 2024 17:12
DFINITYManu pushed a commit that referenced this pull request Nov 19, 2024
Introduce a `VetKdProtocol` trait and implement it for
`CryptoReturningOk`.

The trait is designed so that underneath we can implement the
cryptographic protocol specified in the π<sub>vetbls-agg2</sub> scheme
specified in section 5.3 of the [vetKeys research
paper](https://eprint.iacr.org/2023/616.pdf), in its _optimistic_
variant, where the meaning of optimistic is described in section 9 of
the research paper. The π<sub>vetbls-agg2</sub> scheme is implemented in
[ic-crypto-internal-bls12-381-vetkd](https://github.com/dfinity/ic/blob/master/rs/crypto/internal/crypto_lib/bls12_381/vetkd/src/lib.rs).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants