Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nns): Improve performance of stable neuron recent ballots recording #2697

Merged
merged 11 commits into from
Nov 25, 2024
Merged

fix(nns): Improve performance of stable neuron recent ballots recording #2697

merged 11 commits into from
Nov 25, 2024

Conversation

max-dfinity
Copy link
Contributor

@max-dfinity max-dfinity commented Nov 19, 2024 •
edited
Loading

This improves the performance of recording recent ballots in stable memory by over 90% (in the worst case).

This PR contains migration code for ballots which cannot be rolled back after it is deployed.

Prev | Next

@github-actions github-actions bot added the feat label Nov 19, 2024
@max-dfinity max-dfinity force-pushed the msum/stable-neuron-support-F branch from 8b34320 to 9f8e8e3 Compare November 19, 2024 20:05
@max-dfinity max-dfinity changed the title feat(nns): Support async multi-message voting fix(nns): Improve performance of stable neuron recent ballots recording Nov 19, 2024
@github-actions github-actions bot added fix and removed feat labels Nov 19, 2024
This was referenced Nov 19, 2024
Merged
Closed
@max-dfinity max-dfinity changed the base branch from master to msum/stable-neuron-support-E November 19, 2024 20:09
@max-dfinity max-dfinity force-pushed the msum/stable-neuron-support-F branch 4 times, most recently from 1654ba1 to 1d2fdc9 Compare November 19, 2024 21:39
github-merge-queue bot pushed a commit that referenced this pull request Nov 19, 2024
@max-dfinity
refactor(nns): Make cast_vote_and_cascade_follow async (#2670)
1d73be3 
This gets us closer into the position where we can scale the voting
calculations across multiple messages.

[Prev](#2600) |
[Next](#2697)
Base automatically changed from msum/stable-neuron-support-E to master November 19, 2024 21:46
@max-dfinity max-dfinity force-pushed the msum/stable-neuron-support-F branch from 1d2fdc9 to 2b2c636 Compare November 19, 2024 22:15
aterga pushed a commit that referenced this pull request Nov 20, 2024
@max-dfinity @aterga
refactor(nns): Make cast_vote_and_cascade_follow async (#2670)
ce360d7 
This gets us closer into the position where we can scale the voting
calculations across multiple messages.

[Prev](#2600) |
[Next](#2697)
@max-dfinity max-dfinity force-pushed the msum/stable-neuron-support-F branch 2 times, most recently from 3d6c829 to 0b23a8d Compare November 21, 2024 19:56
@max-dfinity max-dfinity force-pushed the msum/stable-neuron-support-F branch from 0b23a8d to 0e75bd8 Compare November 21, 2024 20:00
@max-dfinity max-dfinity marked this pull request as ready for review November 21, 2024 20:06
@max-dfinity max-dfinity requested a review from a team as a code owner November 21, 2024 20:06
@max-dfinity max-dfinity force-pushed the msum/stable-neuron-support-F branch from 0e75bd8 to 731ad76 Compare November 21, 2024 20:20
jasonz-dfinity
jasonz-dfinity reviewed Nov 22, 2024
View reviewed changes
rs/nns/governance/src/storage/neurons.rs Outdated Show resolved Hide resolved
rs/nns/governance/src/neuron/types.rs Outdated Show resolved Hide resolved
rs/nns/governance/src/neuron/types.rs Show resolved Hide resolved
@max-dfinity max-dfinity force-pushed the msum/stable-neuron-support-F branch from ce116e8 to 7ebd471 Compare November 22, 2024 21:15
@max-dfinity max-dfinity force-pushed the msum/stable-neuron-support-F branch 2 times, most recently from 6c228d8 to 423e30a Compare November 22, 2024 21:33
jasonz-dfinity
jasonz-dfinity previously approved these changes Nov 22, 2024
View reviewed changes
@max-dfinity max-dfinity force-pushed the msum/stable-neuron-support-F branch from 423e30a to bdbf3e1 Compare November 23, 2024 00:16
@max-dfinity max-dfinity force-pushed the msum/stable-neuron-support-F branch from bdbf3e1 to 411e0a5 Compare November 23, 2024 00:19
@max-dfinity max-dfinity added this pull request to the merge queue Nov 25, 2024
Merged via the queue into master with commit ae295d0 Nov 25, 2024
24 checks passed
@max-dfinity max-dfinity deleted the msum/stable-neuron-support-F branch November 25, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-lee-work andrew-lee-work andrew-lee-work left review comments

@jasonz-dfinity jasonz-dfinity jasonz-dfinity approved these changes

Assignees
No one assigned
Labels
fix @nns-team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@max-dfinity @andrew-lee-work @jasonz-dfinity