Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [NODE-1530] Allow local network to access metrics through firewall #2703

Merged
merged 7 commits into from
Nov 22, 2024
Merged

feat: [NODE-1530] Allow local network to access metrics through firewall #2703

merged 7 commits into from
Nov 22, 2024

Conversation

Bownairo
Copy link
Member

No description provided.

@github-actions github-actions bot added the feat label Nov 19, 2024
@Bownairo Bownairo requested a review from a team November 19, 2024 23:31
@Bownairo Bownairo marked this pull request as ready for review November 19, 2024 23:32
@Bownairo Bownairo requested a review from a team as a code owner November 19, 2024 23:32
@Bownairo Bownairo requested a review from a team as a code owner November 20, 2024 00:49
@Bownairo Bownairo requested a review from sasa-tomic November 20, 2024 16:28
andrewbattat
andrewbattat previously approved these changes Nov 20, 2024
View reviewed changes
sasa-tomic
sasa-tomic previously approved these changes Nov 20, 2024
View reviewed changes
ic-os/components/networking/nftables/hostos/nftables.template Outdated Show resolved Hide resolved
@Bownairo Bownairo requested a review from a team November 20, 2024 23:07
@Bownairo Bownairo changed the title feat: Allow local network to access metrics through firewall feat: [NODE-1530] Allow local network to access metrics through firewall Nov 20, 2024
@Bownairo Bownairo dismissed stale reviews from sasa-tomic and andrewbattat via ee9eb5a November 21, 2024 15:07
@Bownairo Bownairo enabled auto-merge November 22, 2024 16:13
@Bownairo Bownairo added this pull request to the merge queue Nov 22, 2024
Merged via the queue into master with commit a0be7ba Nov 22, 2024
25 checks passed
@Bownairo Bownairo deleted the eero/local-metrics branch November 22, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sasa-tomic sasa-tomic sasa-tomic left review comments

@andrewbattat andrewbattat andrewbattat approved these changes

@slawomirbabicz slawomirbabicz slawomirbabicz approved these changes

@eichhorl eichhorl eichhorl approved these changes

Assignees
No one assigned
Labels
@consensus @dre feat @node @product-security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Bownairo @sasa-tomic @eichhorl @slawomirbabicz @andrewbattat