fix(nns): Avoid cloning heap_neurons to avoid performance penalty #2726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-dfinity
changed the title
aterga
reviewed
Nov 20, 2024
aterga
approved these changes
Nov 20, 2024
jasonz-dfinity
approved these changes
Nov 20, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 22, 2024
# Why There was a recent regression on how we list neurons ready to unstake maturity or spawn. Adding benchmarks for those will help prevent them in the future (although, currently they are not enabled in CI yet). # What Adding benchmarks for `list_ready_to_spawn_neuron_ids` and `list_neurons_ready_to_unstake_maturity`. Additional dimensions are: (1) whether the "active neuron in stable memory" is enabled (2) whether there are actually meaningful return value. # Testing When running against changes in #2726 , we get the following results: --------------------------------------------------- Benchmark: list_ready_to_spawn_neuron_ids_heap total: instructions: 455.22 K (improved by 86.76%) heap_increase: 0 pages (no change) stable_memory_increase: 0 pages (no change) --------------------------------------------------- Benchmark: list_ready_to_spawn_neuron_ids_stable total: instructions: 710.56 M (0.00%) (change within noise threshold) heap_increase: 0 pages (no change) stable_memory_increase: 0 pages (no change) --------------------------------------------------- Benchmark: list_neurons_ready_to_unstake_maturity_heap total: instructions: 463.15 K (improved by 86.54%) heap_increase: 0 pages (no change) stable_memory_increase: 0 pages (no change) --------------------------------------------------- Benchmark: list_neurons_ready_to_unstake_maturity_stable total: instructions: 710.57 M (0.00%) (change within noise threshold) heap_increase: 0 pages (no change) stable_memory_increase: 0 pages (no change) ---------------------------------------------------
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a regression in a previous change that causes performance for heartbeats to drop while still using heap neurons. This fixes the method to use Cow instead, so that heap neurons are not unnecessarily cloned.