test(sns): Add a few unit tests of refresh_cached_upgrade_steps and initiate_upgrade_if_sns_behind_target_version #2730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anchpop
changed the title
anchpop
force-pushed
the
@anchpop/tests
branch
from
f2ac3d2 to
3b3c58a
Compare
aterga
reviewed
Nov 21, 2024
aterga
reviewed
Nov 21, 2024
aterga
reviewed
Nov 21, 2024
aterga
approved these changes
Nov 21, 2024
anchpop
force-pushed
the
@anchpop/tests
branch
3 times, most recently
from
bc2157e to
cf99da7
Compare
anchpop
force-pushed
the
@anchpop/tests
branch
from
cf99da7 to
faea5fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I wanted to cover was
Ensuring
initiate_upgrade_if_sns_behind_target_versionwould be properly blocked by other upgrade proposals and pending upgradesEnsuring
refresh_cached_upgrade_stepsdoesn't do anything crazy when SNS-W gives a weird or erroneous response