test(ICRC_Ledger): FI-1589: Adapt icrc golden state tests to ledger V3 stable structures migration #2739
Conversation
mbjorkqvist
force-pushed
the
mathias-FI-1589-adapt-icrc-golden-state-tests-to-V3
branch
from
fb22395 to
e96ab18
Compare
|
The ICRC golden state tests succeeded for commit |
|
Should we also adopt the tests from https://sourcegraph.com/github.com/dfinity/ic/-/blob/rs/nervous_system/integration_tests/tests/sns_ledger_upgrade.rs?L29 |
From a quick glance, neither of those test would seem to need updating, since they both first install the SNS using the mainnet canister versions (which is the latest blessed versions, i.e., for the ledger, "V2", which writes the ledger state using the The problem is with (SNS) ledgers that haven't upgraded to V2, since we don't support upgrading from a pre-V2 version to V3 or later (to migrate the Allowances in V3 to a virtual memory managed by the Since SNSs can (currently?) only upgrade one version at a time, and not skip versions, there shouldn't be any issues, but let's perhaps sync offline to see if there are any potential gaps that we haven't considered. |
…sts-to-V3 # Conflicts: # Cargo.lock # packages/icrc-ledger-types/src/icrc1/account.rs # rs/ledger_suite/icrc1/ledger/src/lib.rs # rs/ledger_suite/icrc1/ledger/src/main.rs # rs/ledger_suite/icrc1/ledger/tests/tests.rs # rs/ledger_suite/icrc1/tests/upgrade_downgrade.rs # rs/ledger_suite/icrc1/tokens_u256/BUILD.bazel # rs/ledger_suite/icrc1/tokens_u256/Cargo.toml # rs/ledger_suite/icrc1/tokens_u256/src/lib.rs # rs/ledger_suite/tests/sm-tests/src/lib.rs
mbjorkqvist
deleted the
mathias-FI-1589-adapt-icrc-golden-state-tests-to-V3
branch
The ICRC ledger does not support downgrading once allowances have been migrated to stable structures. This PR adapts the golden state tests accordingly.