feat(IDX): don't rely on bazel cache for large test deps #2752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the system tests to not assume that big dependencies like ic-os images are present in the Bazel cache. In particular, this adds an upload script (`upload_systest_dep.sh`) which is run by the "local" (non-farm-host) test runner to ensure that the images have been "stored". Currently the meaning of "stored" means that the images are in the `bazel-remote` cache, though this is now an implementation detail, encapsulated in the `upload_systest_dep` script. This ensures that images are always ready when the tests are run, even if the remote bazel cache was previously prune. This also gives us more flexibility for implementing the Bazel cache differently. This also simplifies the bazel build by not requiring both a URL & a sha256 file for images; instead the file can be propagated directly.
basvandijk
approved these changes
Nov 21, 2024
nmattia
commented
Nov 22, 2024
basvandijk
reviewed
Nov 22, 2024
Co-authored-by: Bas van Dijk <[email protected]>
basvandijk
approved these changes
Nov 22, 2024
andrewbattat
approved these changes
Nov 22, 2024
nmattia
added a commit
that referenced
this pull request
Nov 22, 2024
A previous [change](#2752) zealously changed more environment variables than necessary. The `ENV_DEPS__DEV_SETUPOS_IMG_TAR_ZST` should not point to a CAS URL but to the image itself.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 22, 2024
A previous [change](#2752) zealously changed more environment variables than necessary. The `ENV_DEPS__DEV_SETUPOS_IMG_TAR_ZST` should not point to a CAS URL but to the image itself.
nmattia
added a commit
that referenced
this pull request
Nov 23, 2024
…)" This reverts commit e9f61b8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the system tests to not assume that big dependencies like ic-os images are present in the Bazel cache.
In particular, this adds an upload script (
upload_systest_dep.sh) which is run by the "local" (non-farm-host) test runner to ensure that the images have been "stored". Currently the meaning of "stored" means that the images are in thebazel-remotecache, though this is now an implementation detail, encapsulated in theupload_systest_depscript.This ensures that images are always ready when the tests are run, even if the remote bazel cache was previously prune. This also gives us more flexibility for implementing the Bazel cache differently. This also simplifies the bazel build by not requiring both a URL & a sha256 file for images; instead the file can be propagated directly.