Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(node): Replace mac_address with deterministic_ips #2757

Merged
merged 8 commits into from
Nov 22, 2024
Merged

refactor(node): Replace mac_address with deterministic_ips #2757

merged 8 commits into from
Nov 22, 2024

Conversation

Bownairo
Copy link
Member

@Bownairo Bownairo commented Nov 22, 2024 •
edited by andrewbattat
Loading

@Bownairo Bownairo changed the title Replace mac_address with deterministic_ips feat: Replace mac_address with deterministic_ips Nov 22, 2024
@github-actions github-actions bot added the feat label Nov 22, 2024
@Bownairo Bownairo force-pushed the eero/switch-mac branch 2 times, most recently from 4535627 to 25749c2 Compare November 22, 2024 18:16
@Bownairo Bownairo force-pushed the eero/switch-mac branch 2 times, most recently from c1da4a3 to 84756b7 Compare November 22, 2024 19:01
@Bownairo Bownairo marked this pull request as ready for review November 22, 2024 19:51
@Bownairo Bownairo requested review from a team as code owners November 22, 2024 19:51
@Bownairo Bownairo added this pull request to the merge queue Nov 22, 2024
@Bownairo Bownairo removed this pull request from the merge queue due to a manual request Nov 22, 2024
@Bownairo Bownairo changed the title feat: Replace mac_address with deterministic_ips feat: [NODE-1327] Replace mac_address with deterministic_ips Nov 22, 2024
@Bownairo Bownairo added this pull request to the merge queue Nov 22, 2024
@andrewbattat andrewbattat changed the title feat: [NODE-1327] Replace mac_address with deterministic_ips refactor(node): Replace mac_address with deterministic_ips Nov 22, 2024
@github-actions github-actions bot removed the feat label Nov 22, 2024
Merged via the queue into master with commit 245e13e Nov 22, 2024
33 checks passed
@Bownairo Bownairo deleted the eero/switch-mac branch November 22, 2024 21:12
nmattia added a commit that referenced this pull request Nov 23, 2024
@nmattia
Revert "feat: [NODE-1327] Replace mac_address with `deterministic_i…
a9fb13b 
…ps` (#2757)"

This reverts commit 245e13e.

The commit seems to introduce issues in nested tests.
@nmattia nmattia mentioned this pull request Nov 23, 2024
Merged
nmattia added a commit that referenced this pull request Nov 23, 2024
@nmattia
fix: Revert "feat: [NODE-1327] Replace mac_address with `determinis…
8869fff 
…tic_ips` (#2785)

This reverts commit 245e13e (#2757)

The commit seems to introduce issues in nested tests.
@andrewbattat andrewbattat mentioned this pull request Nov 23, 2024
Closed
@Bownairo Bownairo restored the eero/switch-mac branch November 25, 2024 17:08
@Bownairo Bownairo mentioned this pull request Nov 25, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Nov 26, 2024
@Bownairo @andrewbattat
refactor: [NODE-1155] Replace mac_address with deterministic_ips (#…
2f4c1fc 
…2810)

Following #2757 and
#2785, with a fix to MAC generation on
HostOS that was caught by hourly.

---------

Co-authored-by: Andrew Battat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewbattat andrewbattat andrewbattat approved these changes

@basvandijk basvandijk basvandijk approved these changes

Assignees
No one assigned
Labels
@idx @node refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bownairo @basvandijk @andrewbattat