test(sns): Add unit tests for automatic upgrades triggered when target version ahead of deployed version #2784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anchpop
force-pushed
the
@anchpop/more-unit-tests
branch
4 times, most recently
from
e18b9bc to
104905d
Compare
max-dfinity
reviewed
Nov 25, 2024
max-dfinity
reviewed
Nov 25, 2024
rs/sns/governance/src/governance/advance_target_sns_version_tests.rs
Outdated
Show resolved
Hide resolved
max-dfinity
approved these changes
Nov 25, 2024
aterga
reviewed
Nov 25, 2024
rs/sns/governance/src/governance/advance_target_sns_version_tests.rs
Outdated
Show resolved
Hide resolved
aterga
reviewed
Nov 25, 2024
rs/sns/governance/src/governance/advance_target_sns_version_tests.rs
Outdated
Show resolved
Hide resolved
anchpop
force-pushed
the
@anchpop/more-unit-tests
branch
2 times, most recently
from
fee5473 to
e761663
Compare
anchpop
force-pushed
the
@anchpop/more-unit-tests
branch
from
e761663 to
9eb6e6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contributes unit tests of the whole automatic-upgrade process (as triggered by target_version being set). It adds a test for Governance and Root.
Why add unit tests when we already have integration tests?
Certain scenarios are much easier to test via unit testing. These tests lay the groundwork for a test I want to write which will exercise edge cases w.r.t. archive canisters, which are too hard to exercise in an integration test