Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(IDX): allow more time for //rs/nervous_system/integration_tests:... #3059

Merged

Conversation

basvandijk
Copy link
Collaborator

@basvandijk basvandijk commented Dec 9, 2024

Since the //rs/nervous_system/integration_tests:... tests often time out we increase their timeout from 5 to 15 minutes. If it turns out their P90 duration will go over 5 minutes we'll tag them as long_test to no longer run them on PRs but only on pushes to master.

Additionally since //rs/nervous_system/integration_tests:integration_tests_test_tests/sns_ledger_upgrade ran into a timeout we isolate it into its own bazel target deploy_fresh_sns_test and add more logs.

Since the `//rs/nervous_system/integration_tests:...` tests often
time out we increase their timeout from 5 to 15 minutes.

Additionally since `//rs/nervous_system/integration_tests:integration_tests_test_tests/sns_ledger_upgrade`
[ran into a timeout](https://dash.zh1-idx1.dfinity.network/invocation/eda26713-6f08-4f88-94c8-cacebd92ad50?target=%2F%2Frs%2Fnervous_system%2Fintegration_tests%3Aintegration_tests_test_tests%2Fsns_ledger_upgrade&targetStatus=11)
we isolate it into its own bazel target `deploy_fresh_sns_test`
and add more logs.
@github-actions github-actions bot added the test label Dec 9, 2024
@basvandijk basvandijk marked this pull request as ready for review December 9, 2024 15:47
@basvandijk basvandijk requested a review from a team as a code owner December 9, 2024 15:47
@basvandijk basvandijk enabled auto-merge December 9, 2024 15:57
@basvandijk basvandijk added this pull request to the merge queue Dec 9, 2024
Merged via the queue into master with commit 90f4535 Dec 9, 2024
27 checks passed
@basvandijk basvandijk deleted the basvandijk/more-nervous-system-integration-test-debugging branch December 9, 2024 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants