Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(CON-1413): Create local transcripts for Vetkeys #3387

Merged
merged 59 commits into from
Feb 10, 2025
Merged

feat(CON-1413): Create local transcripts for Vetkeys #3387

merged 59 commits into from
Feb 10, 2025

Conversation

Sawchord
Copy link
Contributor

@Sawchord Sawchord commented Jan 9, 2025 •
edited
Loading

This PR adds functionality to generate local NiDkg transcripts for Vetkeys to the DKG component.

  • Introduce get_enabled_vet_keys to get all NiDKG key ids from the ChainKeyConfig.
  • Introduce the tags_iter function, which iterates over LowThreshold and HighThreshold as well as provided HighThresholdForKeyId variants off NiDkgTag
  • Unit tests to capture the new behaviour
  • Adapt test code
  • Adapt CUP loading functions to load the initializations

@github-actions github-actions bot added the feat label Jan 9, 2025
@Sawchord Sawchord changed the title feat(CON-1431): Create local transcripts for Vetkeys feat(CON-1413): Create local transcripts for Vetkeys Jan 13, 2025
@Sawchord Sawchord marked this pull request as ready for review February 3, 2025 11:28
@Sawchord Sawchord requested review from a team as code owners February 3, 2025 11:28
eichhorl
eichhorl reviewed Feb 3, 2025
View reviewed changes
rs/consensus/dkg/src/utils.rs Outdated Show resolved Hide resolved
rs/consensus/dkg/src/payload_builder.rs Show resolved Hide resolved
rs/consensus/dkg/src/payload_builder.rs Show resolved Hide resolved
eichhorl
eichhorl approved these changes Feb 6, 2025
View reviewed changes
rs/consensus/dkg/src/payload_builder.rs Show resolved Hide resolved
rs/consensus/dkg/src/payload_builder.rs Outdated Show resolved Hide resolved
@Sawchord Sawchord requested a review from fspreiss February 6, 2025 15:39
fspreiss
fspreiss approved these changes Feb 7, 2025
View reviewed changes
Copy link
Member

@fspreiss fspreiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Sawchord! Changes for ic-interface-owners (in rs/test_utilities_registry) LGTM.

(I glanced over the Consensus code only from a very high level as I'm not familiar with that code, but what I saw looked reasonable)

rs/test_utilities/registry/src/lib.rs Outdated Show resolved Hide resolved
rs/test_utilities/registry/src/lib.rs Outdated Show resolved Hide resolved
rs/consensus/dkg/src/utils.rs Outdated Show resolved Hide resolved
rs/consensus/dkg/src/utils.rs Outdated Show resolved Hide resolved
rs/consensus/dkg/src/payload_builder.rs Show resolved Hide resolved
@Sawchord Sawchord changed the title feat(CON-1413): Create local transcripts for Vetkeys feat(CON-1413, CON-1414, CON-1417): Create local transcripts for Vetkeys Feb 10, 2025
@Sawchord Sawchord changed the title feat(CON-1413, CON-1414, CON-1417): Create local transcripts for Vetkeys feat(CON-1413): Create local transcripts for Vetkeys Feb 10, 2025
@Sawchord Sawchord enabled auto-merge February 10, 2025 16:26
@Sawchord Sawchord added this pull request to the merge queue Feb 10, 2025
Merged via the queue into master with commit 0ff90c2 Feb 10, 2025
27 of 28 checks passed
@Sawchord Sawchord deleted the leon/vet_kd_dkg branch February 10, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eichhorl eichhorl eichhorl approved these changes

@fspreiss fspreiss fspreiss approved these changes

Assignees
No one assigned
Labels
@consensus feat @ic-interface-owners
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sawchord @fspreiss @eichhorl