test(ICRC_Ledger): FI-1625: Adapt golden state test to V4 migration #3397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciejdfinity
approved these changes
Jan 10, 2025
|
The FI nightly tests passed when running on commit 0e4b51c457fcce0ff316cee8e4a784e79e71a089 here. |
mbjorkqvist
deleted the
mathias-FI-1625-adapt-icrc-golden-state-tests-to-V4
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt the ICRC golden state test to handle the case where some canisters have already been upgraded to the V4 version, and further no migration is expected to happen if they are upgraded to the same version again.