feat(governance-tools): Pretty add-release-to-changelog.sh output. #3417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-wong-dfinity-org
force-pushed
the
pretty-add-release-to-changelog-daniel-wong
branch
from
781e3fc to
5ff8d89
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
If this pull request affects the behavior of any canister owned by
the Governance team, remember to update the corresponding
unreleased_changes.md file(s).
To acknowldge this reminder (and unblock the PR), dismiss this
code review by going to the bottom of the pull request page, and
supply one of the following reasons:
-
Done.
-
No canister behavior changes.
daniel-wong-dfinity-org
dismissed
github-actions[bot]’s stale review
No canister behavior changes.
daniel-wong-dfinity-org
changed the base branch from
master
to
add-entries-to-sns-changelog-daniel-wong
daniel-wong-dfinity-org
changed the title
anchpop
approved these changes
Jan 13, 2025
Base automatically changed from
add-entries-to-sns-changelog-daniel-wong
to
master
January 14, 2025 16:37
…but not just that.
daniel-wong-dfinity-org
force-pushed
the
pretty-add-release-to-changelog-daniel-wong
branch
from
5ff8d89 to
ed0a022
Compare
daniel-wong-dfinity-org
removed this pull request from the merge queue due to a manual request
daniel-wong-dfinity-org
deleted the
pretty-add-release-to-changelog-daniel-wong
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More Precisely, What
Added a success message.
Added emojis.
Changed informational messages from purple to cyan. I think dark grey would be best, but we don't (yet) have a function for that; cyan seems like the next best thing.
Why
Silence is a highly ambiguous way to communicate.