chore: bump rust to 1.84 #3469
Merged
chore: bump rust to 1.84 #3469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…be27b3fbbc4d7bed681ec8486f8b1d Image tag: b3869ba20c4e9ba2915be302f5b5a4b23da0545af2f1cb896441055372950389
|
Run URL: https://github.com/dfinity/ic/actions/runs/12806865549 New container image: |
schneiderstefan
approved these changes
Jan 20, 2025
gregorydemay
approved these changes
Jan 20, 2025
blind-oracle
approved these changes
Jan 20, 2025
mraszyk
reviewed
Jan 20, 2025
eichhorl
approved these changes
Jan 20, 2025
altkdf
approved these changes
Jan 20, 2025
mraszyk
approved these changes
Jan 20, 2025
DSharifi
dismissed
github-actions[bot]’s stale review
No canister behavior changes.
tomer-dfinity
approved these changes
Jan 20, 2025
yvonneanne
approved these changes
Jan 20, 2025
fspreiss
approved these changes
Jan 20, 2025
marko-k0
approved these changes
Jan 20, 2025
oggy-dfin
approved these changes
Jan 20, 2025
daniel-wong-dfinity-org
approved these changes
Jan 20, 2025
basvandijk
approved these changes
Jan 20, 2025
Bownairo
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the rust version of the repo to 1.84.
rules_rusthas been upgraded from 0.54.1 to 0.56.0. This is necessary as rust 1.84 removed the targetwasm32-wasiand renamed it towasm32-wasip1.rules_ruestversions pre0.55.0referencewasm32-wasiwhich as a consequence leads to build error. https://github.com/bazelbuild/rules_rust/releases/tag/0.55.0compile_dataflag for data that is only needed at compile time. This is a change that was added in rules_rust0.55.0. See makedataruntime-only to align with ecosystem norms bazelbuild/rules_rust#2977.//rs/nns/governance:governance-canbench_testhas also been updated as it failed on CI.ic-ledger-suite-orchestrator-canister.wasm.gzhas been increased from17mb to18mb.