feat(rosetta): Support pagination for Rosetta API list_neurons

[max-dfinity]

No description provided.

[fsodre]

Thanks for working on this.

Ar there tests showing the new behavior works as expected and also that it's not breaking for people that are not specifying a page number?

[max-dfinity]

@fsodre No, I did not add tests. It definitely wouldn't be breaking for users not specifying page number since that's what the tests are already doing.

Is there an efficient way to create more than 500 neurons in Rosetta tests? If not, we would need to additionally add the page_size parameter to the Rosetta API, but I was hoping to keep the changes in rosetta as minimal as possible, since many other parameters are already not provided.

[fsodre]

Hi. I believe it shouldn't be hard to add another scenario to this test case, in which neurons can be easily created.

[max-dfinity]

@fsodre
I tried looping and creating enough neurons to test the paging, but ran into a few problems.

There is a neuron creation limit in the Governance API. I tried advancing time, and got the following errors in the tests (this is just a sample, there were about 10 of the first, and hundreds of the second (as I was trying to create 501 neurons).

2025-02-05T01:32:36.713175Z ERROR rs/rosetta-api/icp/src/ledger_client.rs:712: Error submitting transaction TransactionIdentifier(TransactionIdentifier { hash: "0000000000000000000000000000000000000000000000000000000000000000" }): Operation took longer than 20s to complete..


2025-02-05T01:32:53.546703Z ERROR rs/rosetta-api/icp/src/ledger_client.rs:712: Error submitting transaction TransactionIdentifier(TransactionIdentifier { hash: "18413cff148a7eee3650b3d3629071820edbceb7e28eafb5e5f622f94c9cf02f" }): Operation took longer than 20s to complete..

Any ideas?

[fsodre]

Thanks for trying to add the tests, it seems like we have infra limitations there for now. Let's ship this change without it and work on it as a follow up.