Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [EXC-1836] Update hook status after update of canister settings #3624

Merged
merged 8 commits into from
Jan 31, 2025
Merged

fix: [EXC-1836] Update hook status after update of canister settings #3624

merged 8 commits into from
Jan 31, 2025

Conversation

dragoljub-duric
Copy link
Contributor

@dragoljub-duric dragoljub-duric commented Jan 27, 2025 •
edited
Loading

The PR adds a check condition for the low_wasm_memory hook when canister settings are updated because changes of wasm_memory_threshold or wasm_memory_limit or memory_allocation can trigger or un-trigger hook condition.

@github-actions github-actions bot added the fix label Jan 27, 2025
@dragoljub-duric dragoljub-duric marked this pull request as ready for review January 27, 2025 13:08
@dragoljub-duric dragoljub-duric requested a review from a team as a code owner January 27, 2025 13:08
@dragoljub-duric dragoljub-duric mentioned this pull request Jan 27, 2025
Open
@dragoljub-duric dragoljub-duric changed the title fix: Update hook status after setting wasm_memory_threshold fix: Update hook status after update of canister settings. Jan 27, 2025
@dragoljub-duric dragoljub-duric changed the title fix: Update hook status after update of canister settings. fix: [EXC-1836] Update hook status after update of canister settings Jan 27, 2025
@dragoljub-duric dragoljub-duric added this pull request to the merge queue Jan 31, 2025
Merged via the queue into master with commit ef59572 Jan 31, 2025
25 checks passed
@dragoljub-duric dragoljub-duric deleted the EXC-1836-update-hook-status-after-setting-wasm-memory-threshold branch January 31, 2025 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adambratschikaye adambratschikaye adambratschikaye approved these changes

Assignees
No one assigned
Labels
@execution fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dragoljub-duric @adambratschikaye