test(crypto): CRP-2599 add smoke test for VetKdProtocol impl #3649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
If this pull request affects the behavior of any canister owned by
the Governance team, remember to update the corresponding
unreleased_changes.md file(s).
To acknowldge this reminder (and unblock the PR), dismiss this
code review by going to the bottom of the pull request page, and
supply one of the following reasons:
-
Done.
-
No canister behavior changes.
fspreiss
dismissed
github-actions[bot]’s stale review
No canister behavior changes.
Sorry for the noise! Had to do some git acrobatics to solve an issue for IDX. |
altkdf
approved these changes
Jan 29, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 31, 2025
…ent (#3565) Implements the `VetKdProtocol` trait for the `CryptoComponent` Smoke tests are added in #3649. They are split from this PR to make the PR review easier. --------- Co-authored-by: Jack Lloyd <[email protected]>
Base automatically changed from
franzstefan/CRP-2599-vetkdprotocol-impl
to
master
January 31, 2025 10:50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds smoke tests for the VetKdProtocol trait implementation added in #3565