Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pocket-ic): support custom blockmaker metrics at each round #3685

Merged
merged 31 commits into from
Feb 3, 2025
Merged

feat(pocket-ic): support custom blockmaker metrics at each round #3685

merged 31 commits into from
Feb 3, 2025

Conversation

pietrodimarco-dfinity
Copy link
Contributor

@pietrodimarco-dfinity pietrodimarco-dfinity commented Jan 30, 2025 •
edited
Loading

Currently PocketIC at each tick() executes a round with state_machine_tests. However a dummy blockmaker is used.

The metrics_collector_canister I am building store and serve node metrics from all the subnet. To test this canister I need then to modify PocketIC so that at each "round" it stores blockmaker metrics that I can pass in from tests

@pietrodimarco-dfinity pietrodimarco-dfinity requested review from a team as code owners January 30, 2025 11:12
schneiderstefan
schneiderstefan reviewed Jan 30, 2025
View reviewed changes
rs/state_machine_tests/src/lib.rs Outdated Show resolved Hide resolved
rs/state_machine_tests/src/lib.rs Outdated Show resolved Hide resolved
rs/state_machine_tests/src/lib.rs Outdated Show resolved Hide resolved
@pietrodimarco-dfinity pietrodimarco-dfinity marked this pull request as draft January 30, 2025 11:30
@pietrodimarco-dfinity pietrodimarco-dfinity changed the title Adapt pocketIC to customize blockmaker at each round feat(pocket-ic): support custom blockmakers at each round Jan 30, 2025
@pietrodimarco-dfinity pietrodimarco-dfinity marked this pull request as ready for review January 31, 2025 17:32
mraszyk
mraszyk approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@mraszyk mraszyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution to PocketIC!

@pietrodimarco-dfinity pietrodimarco-dfinity added this pull request to the merge queue Feb 3, 2025
Merged via the queue into master with commit 24b22b8 Feb 3, 2025
26 checks passed
@pietrodimarco-dfinity pietrodimarco-dfinity deleted the pmarco/add-pocketic-blockmakers branch February 3, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mraszyk mraszyk mraszyk approved these changes

@schneiderstefan schneiderstefan Awaiting requested review from schneiderstefan

@dsarlis dsarlis Awaiting requested review from dsarlis

Assignees
No one assigned
Labels
@execution feat @ic-message-routing-owners
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pietrodimarco-dfinity @dsarlis @mraszyk @schneiderstefan