chore(IDX): track ict changes with bazel #3705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simplifies the `ict` wrapper script. The script now relies on bazel to figure out if the `ict` tool needs to be rebuilt. From basic testing, this seems fast enough for a good CLI experience and simplifies things a fair bit (avoid custom hashing & checksum file): ```sh $ time ./bin/ict -v ict version 0.1.2 real 0m0.345s user 0m0.016s sys 0m0.042s ```
basvandijk
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the
ictwrapper script. The script now relies on bazel to figure out if theicttool needs to be rebuilt.From basic testing, this seems fast enough for a good CLI experience and simplifies things a fair bit (avoid custom hashing & checksum file):
$ time ./bin/ict -v ict version 0.1.2 real 0m0.345s user 0m0.016s sys 0m0.042s