feat(nervous-system): release runscript automatically creates changelog PRs #3806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anchpop
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
If this pull request affects the behavior of any canister owned by
the Governance team, remember to update the corresponding
unreleased_changes.md file(s).
To acknowldge this reminder (and unblock the PR), dismiss this
code review by going to the bottom of the pull request page, and
supply one of the following reasons:
-
Done.
-
No canister behavior changes.
anchpop
force-pushed
the
@anchpop/create-changelog-prs
branch
2 times, most recently
from
1293d2c to
3db6f40
Compare
anchpop
dismissed
github-actions[bot]’s stale review
No canister behavior changes.
anchpop
force-pushed
the
@anchpop/create-changelog-prs
branch
from
3db6f40 to
c242bb2
Compare
max-dfinity
reviewed
Feb 5, 2025
max-dfinity
reviewed
Feb 5, 2025
max-dfinity
approved these changes
Feb 5, 2025
anchpop
force-pushed
the
@anchpop/utils-file
branch
from
4e9b9e1 to
5734b25
Compare
anchpop
force-pushed
the
@anchpop/create-changelog-prs
branch
2 times, most recently
from
9d29b35 to
71bd94e
Compare
anchpop
force-pushed
the
@anchpop/utils-file
branch
2 times, most recently
from
cb374fd to
53de069
Compare
anchpop
force-pushed
the
@anchpop/create-changelog-prs
branch
2 times, most recently
from
e7b0579 to
b3c25d9
Compare
anchpop
force-pushed
the
@anchpop/utils-file
branch
2 times, most recently
from
d3d5d48 to
96e2be9
Compare
anchpop
force-pushed
the
@anchpop/create-changelog-prs
branch
from
b3c25d9 to
1bdb00e
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
daniel-wong-dfinity-org
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the final step in the release process. Now everything is automated!
Here is an example of a PR it creates: #3807
To create the PR, we use
gh, which we assert you have on your computer before the first step. (This ensures that you don't get to the last step and then hit an error which would be slightly annoying to recover from. Instead, you get the error right away, and it should be smooth sailing after that.)The intention of this change is that you create the PR to update the changelog right when you create the proposals.
A consequence of is that the changelog now shows the date of proposal submission, rather than execution.
← Previous PR