chore: [EXC-1835] Make ic-management-canister-types private #3814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
If this pull request affects the behavior of any canister owned by
the Governance team, remember to update the corresponding
unreleased_changes.md file(s).
To acknowldge this reminder (and unblock the PR), dismiss this
code review by going to the bottom of the pull request page, and
supply one of the following reasons:
-
Done.
-
No canister behavior changes.
michael-weigelt
dismissed
github-actions[bot]’s stale review
No canister behavior changes.
schneiderstefan
approved these changes
Feb 6, 2025
basvandijk
approved these changes
Feb 6, 2025
dsarlis
approved these changes
Feb 6, 2025
crusso
approved these changes
Feb 6, 2025
eichhorl
approved these changes
Feb 6, 2025
fspreiss
approved these changes
Feb 6, 2025
max-dfinity
approved these changes
Feb 6, 2025
mraszyk
approved these changes
Feb 7, 2025
gregorydemay
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has no functional changes.
The types in
rs/types/management_canister_typesare private to the implementation, i.e., the execution environment, message routing and some testing crates.Every other user of these types should use the public crate available via crates.io.
Before we can start transitioning existing users to the public crate, we need to solve the naming clash.
In the meantime, existing users are in a temporary Bazel whitelist. When they change their dependency to the public one, we can remove them from the whitelist.
Reviewers: Please note that once the public crate is made available to the repository (in a follow-up PR), we will ask your team to use the public crate - eventually.