Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(registry): Remove obsolete ECDSA API #3827

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

aterga
Copy link
Member

@aterga aterga commented Feb 6, 2025

This PR removes the legacy ECDSA fields from the Registry canister's subnet operations since those were obsolete.

@github-actions github-actions bot added the chore label Feb 6, 2025
@aterga aterga marked this pull request as ready for review February 6, 2025 13:14
@aterga aterga requested review from a team as code owners February 6, 2025 13:14
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this pull request affects the behavior of any canister owned by
the Governance team, remember to update the corresponding
unreleased_changes.md file(s).

To acknowldge this reminder (and unblock the PR), dismiss this
code review by going to the bottom of the pull request page, and
supply one of the following reasons:

  1. Done.

  2. No canister behavior changes.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this pull request affects the behavior of any canister owned by
the Governance team, remember to update the corresponding
unreleased_changes.md file(s).

To acknowldge this reminder (and unblock the PR), dismiss this
code review by going to the bottom of the pull request page, and
supply one of the following reasons:

  1. Done.

  2. No canister behavior changes.

Copy link
Contributor

@r-birkner r-birkner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BN changes are good :)

Copy link
Contributor

@nmattia nmattia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IDX rubber stamp

@aterga aterga added the CI_ALL_BAZEL_TARGETS Runs all bazel targets and uploads them to S3 label Feb 6, 2025
@aterga aterga enabled auto-merge February 6, 2025 16:44
@aterga aterga added this pull request to the merge queue Feb 6, 2025
Merged via the queue into master with commit 5e85add Feb 6, 2025
43 checks passed
@aterga aterga deleted the arshavir/remove-legacy-ecdsa-api branch February 6, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants