chore(IDX): Simplify versioning #3984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmattia
added
the
CI_ALL_BAZEL_TARGETS
basvandijk
approved these changes
Feb 17, 2025
There was a problem hiding this comment.
I can't see anything wrong with this. It looks like a great simplification!
I am wondering what happened in the past when a PR was labelled with CI_ALL_BAZEL_TARGETS. Were
artifacts uploaded to our CDNs under the all-zeros revision?
And IIUC, this still happens with this PR right?
That's what it looked like! |
andrewbattat
approved these changes
Feb 17, 2025
nikolay-komarevskiy
approved these changes
Feb 17, 2025
LittleChimera
approved these changes
Feb 18, 2025
This simplifies the mechanism used to stamp the released artifacts with a version. In the non-release mode, a constant version is used. In release mode (with `--config=stamp`) the HEAD commit id and timestamp are used. This also removes some workarounds that were necessary to re-trigger bazel evaluation (timestamp file, etc) as well as the distinction between "IC version" and "IC RC-only version". Moreover the upload check (to ensure we don't upload non-release artifacts) is removed because (1) uploads are (currently) always necessary (for SHA256SUMS files) and (2) the check was using an incorrect string in the comparison (couple extra zeros) which meant it never triggers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the mechanism used to stamp the released artifacts with a version.
In the non-release mode, a constant version is used. In release mode (with
--config=stamp) the HEAD commit id and timestamp are used.This also removes some workarounds that were necessary to re-trigger bazel evaluation (timestamp file, etc) as well as the distinction between "IC version" and "IC RC-only version".
Moreover the upload check (to ensure we don't upload non-release artifacts) is removed because (1) uploads are (currently) always necessary (for SHA256SUMS files) and (2) the check was using an incorrect string in the comparison (couple extra zeros) which meant it never triggers.