fix(nns): Fixed a bug where known neuron is not seen as public. #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lculation. The problem is that there are paths where normalization is not applied. This is a bug from a recent change that I did. The solution is to make the Neuron::visibility field private, and add a (public) getter. This obsoletes the previous solution: normalized. Thus, I deleted normalized. This bug was discovered by strengthening an existing test (for public neuron metrics), which then started failing.
jasonz-dfinity
approved these changes
Jul 31, 2024
daniel-wong-dfinity-org
deleted the
fix-neuron-visibility-bug-daniel-wong
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is that there are (many) paths where normalization is not applied. This is a bug from a recent change that I did.
The solution (implemented here) is to make the Neuron::visibility field private, and add a (public) getter.
This obsoletes the previous solution:
fn normalized. Thus, I deletednormalized.This bug was discovered by strengthening an existing test (for public neuron metrics), which then started failing.