Skip to content

Commit

Permalink
Disable macos release build check due to flakyness (#2541)
Browse files Browse the repository at this point in the history
The release build check on macos was very flaky: one in 3 builds fails
due to timeout.
Hence MacOs builds are disabled for now until there is time to look
into a better solution.
  • Loading branch information
Frederik Rothenberger authored Jul 17, 2024
1 parent 84225ac commit 402d6ea
Showing 1 changed file with 3 additions and 9 deletions.
12 changes: 3 additions & 9 deletions .github/workflows/release-build-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -84,20 +84,14 @@ jobs:
needs: latest-release
strategy:
matrix:
# macos-14 is itself virtualized and does not support nested virtualization which would be required for the docker build.
# -> just use macos-13
os: [ ubuntu-22.04, ubuntu-20.04, macos-13 ]
# docker builds on macos are flaky or not supported at all (in case of ARM based runners). The signal they gave
# was minimal, so we will skip them for now until there is a reliable way to run docker images on macos runners.
os: [ ubuntu-22.04, ubuntu-20.04 ]
steps:
- uses: actions/checkout@v4
with:
ref: "refs/tags/${{ needs.latest-release.outputs.ref }}"

- name: Setup docker (missing on MacOS)
if: runner.os == 'macos'
run: |
brew install docker docker-buildx colima
colima start
- name: "Verify Hash"
run: |
./scripts/verify-hash --ii-hash ${{ needs.latest-release.outputs.ii_prod_sha256 }} --archive-hash ${{ needs.latest-release.outputs.archive_sha256 }}
Expand Down

0 comments on commit 402d6ea

Please sign in to comment.