Refactor VC flow e2e tests #2532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR refactors the VC related e2e tests such that the test_app is no longer misused to test alternative origins configurations for the issuer. And because the issuer can now be configured as needed in tests, the call to the provision script in `dfx.json` no longer needs to configure the test app as the issuer derivation origin either. Additionally a new test is added to verify that the VC flow indeed fails on issuer alternative origins misconfiguration.
frederikrothenberger
force-pushed
the
frederik/refactor-tests
branch
from
5334fef to
f5b4040
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the VC related e2e tests such that the test_app is no longer misused to test alternative origins configurations for the issuer.
And because the issuer can now be configured as needed in tests, the call to the provision script in
dfx.jsonno longer needs to configure the test app as the issuer derivation origin either.Additionally a new test is added to verify that the VC flow indeed fails on issuer alternative origins misconfiguration.
🟡 Some screens were changed