Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up after new landing pages #2540

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Clean up after new landing pages #2540

merged 1 commit into from
Jul 17, 2024

Conversation

lmuntaner
Copy link
Collaborator

@lmuntaner lmuntaner commented Jul 16, 2024 •
edited by github-actions bot
Loading

Clean up showcase and code after releasing the new landing pages.

In this PR,

  • Remove "NewLanding" showcase pages but keep one which has a case that wasn't covered.
  • Refactor page helper params to make it clear what the boolean means.
🟢 Some screens were added
🟡 Some screens were changed
🔴 Some screens were removed

@lmuntaner
Copy link
Collaborator Author

@frederikrothenberger please review

@lmuntaner lmuntaner marked this pull request as ready for review July 16, 2024 11:56
@lmuntaner lmuntaner requested a review from a team as a code owner July 16, 2024 11:56
frederikrothenberger
frederikrothenberger approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@frederikrothenberger frederikrothenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm!
Out of curiosity, will the landing page layout also be used for the authorizeUseExisting... variants at some point?

@lmuntaner
Copy link
Collaborator Author

Thanks, lgtm! Out of curiosity, will the landing page layout also be used for the authorizeUseExisting... variants at some point?

I don't think so. It will use another layout, but probably not the split page one.

@lmuntaner lmuntaner added this pull request to the merge queue Jul 17, 2024
Merged via the queue into main with commit 84225ac Jul 17, 2024
65 checks passed
@lmuntaner lmuntaner deleted the lm-clean-up-landing-pages branch July 17, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frederikrothenberger frederikrothenberger frederikrothenberger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lmuntaner @frederikrothenberger