Remove unnecessary counters from persistent state #2639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `StableBTreeMap` tracks the number of elements on its own, so there is no need for an external counter. Removing the extra counters also makes the stats resetting obsolete and hence allows to remove the pre_stats II version from the integration tests.
lmuntaner
reviewed
Oct 2, 2024
Yes, because the fields are optional. Note that we do have explicit upgrade / rollback tests to verify that. |
True, I forgot about them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
StableBTreeMaptracks the number of elements on its own, so there is no need for an external counter.Removing the extra counters also makes the stats resetting obsolete and hence allows to remove the pre_stats II version from the integration tests.