Add new metrics to monitor memory #2650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@frederikrothenberger please review |
frederikrothenberger
changed the title
src/archive/src/main.rs
Outdated
| @@ -575,6 +575,7 @@ fn http_request(req: HttpRequest) -> HttpResponse { | |||
| } | |||
|
|
|||
| fn encode_metrics(w: &mut MetricsEncoder<Vec<u8>>) -> std::io::Result<()> { | |||
| const WASM_PAGE_SIZE_IN_BYTES: f64 = 65536.0; | |||
There was a problem hiding this comment.
There should be a constant for that in the cdk. Also, as a side-note: I would not do floating point calculations unless absolutely necessary. Floating point calculations could introduce rounding errors.
Alarms for memory threshold will be added if we expose this metrics. |
frederikrothenberger
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To introduce new metrics that will be used to monitor the memory usage as requested by security.
Changes
ii_archive_stable_memory_bytes,ii_archive_heap_pagesandii_archive_heap_memory_bytesmetrics to the archive canister.internet_identity_heap_memory_bytesandinternet_identity_stable_memory_bytesmetrics to main II canister.