Switch II front-end to API v2 for registration #2654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederikrothenberger
requested review from
nmattia and
lmuntaner
and removed request for
a team and
nmattia
This PR switches the II front-end to the APIv2. In particular, the front-end is now able to dynamically skip the captcha if it is switched off. Note: This PR does _not_ include e2e tests for switched off captchas. Since this requires a whole new CI setup, I'll do this in another PR.
frederikrothenberger
force-pushed
the
frederik/new-reg-flow-fe
branch
from
302aa30 to
eb12561
Compare
lmuntaner
approved these changes
Oct 17, 2024
| captcha_png_base64: string; | ||
| checkCaptcha: ( | ||
| solution: string | ||
| ) => Promise<Exclude<T, WrongCaptchaSolution> | WrongCaptchaSolution>; |
There was a problem hiding this comment.
What is this type Exclude<T, WrongCaptchaSolution>?
There was a problem hiding this comment.
Because I need to split the type into either a WrongCaptchaSolution or the generic type T. And in order for Typescript to not complain, I needed to make sure that T cannot be WrongCaptchaSolution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches the II front-end to the APIv2. In particular, the front-end is now able to dynamically skip the captcha if it is switched off.
Note: This PR does not include e2e tests for switched off captchas. Since this requires a whole new CI setup, I'll do this in another PR.
🟡 Some screens were changed
🔴 Some screens were removed