Enable PIN registration with query param #2711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmuntaner
commented
Nov 27, 2024
There was a problem hiding this comment.
The changes in this PR are mainly reverting #2687
lmuntaner
commented
Nov 27, 2024
| }; | ||
| } else { | ||
| const identity = savePasskeyResult; | ||
| // TODO: Return something meaningful if getting the passkey identity fails |
There was a problem hiding this comment.
This is the only new line that was not just reverted. Because the view can return undefined.
This is in the current code as well. The way this error was handled before was to never resolve the promise and show a toast error.
lmuntaner
commented
Nov 27, 2024
| export const savePasskeyOrPin = async (): Promise< | ||
| IIWebAuthnIdentity | undefined | ||
| > => { | ||
| export const savePasskeyOrPin = async ({ |
There was a problem hiding this comment.
This is reverted to the old logic if pinAllowed is true and skip to render the page if not enabled.
lmuntaner
commented
Nov 27, 2024
| @@ -123,32 +117,11 @@ test.skip("Should not prompt for PIN after deleting temp key", async () => { | |||
| }, APPLE_USER_AGENT); | |||
| }, 300_000); | |||
|
|
|||
| test.skip("Log into client application using PIN registration flow", async () => { | |||
There was a problem hiding this comment.
This won't be enabled in the foreseeable future.
|
@sea-snake please review |
sea-snake
reviewed
Nov 27, 2024
sea-snake
approved these changes
Nov 27, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 27, 2024
* Reintroduce PIN registration with query param * Enable PIN e2e tests * Fix tests * Use variable for query param in e2e test * Fix e2e test * Remove console.log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In the PR where we deprecated registering with PIN we disabled the e2e tests to login (and register) with PIN.
However, current PIN users can still login with with the PIN and will continue to do so for a while.
Therefore, to keep the e2e coverage we had before, we want to reintroduce the e2e tests that login with the PIN. For that, we also need to reintroduce registering with PIN. We use a query param
enablePinto enable registering with a PIN.Changes
Tests
🟢 Some screens were added
🟡 Some screens were changed