Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add well-known asset for Related Origin Requests #2720

Merged
merged 7 commits into from
Dec 6, 2024

Conversation

lmuntaner
Copy link
Collaborator

@lmuntaner lmuntaner commented Dec 3, 2024

Motivation

Support passkeys from multiple domains.

In this PR, we implement the first step which is an asset: .well-known/webauthn as requested by the standard.

Changes

  • Add new path .well-known/webauth. The value depends on the value in the config.

Tests

  • Tested locally that the file is present.
  • New tests to http to check the new asset is present in different scenarios.

🟡 Some screens were changed

@lmuntaner lmuntaner marked this pull request as ready for review December 3, 2024 10:24
@lmuntaner lmuntaner requested a review from a team as a code owner December 3, 2024 10:24
@lmuntaner lmuntaner requested review from sea-snake and LXIF December 3, 2024 10:24
@lmuntaner
Copy link
Collaborator Author

@LXIF @sea-snake please review

@lmuntaner lmuntaner marked this pull request as draft December 4, 2024 13:24
@lmuntaner lmuntaner force-pushed the lm-add-well-known-ROR-standard branch from 2ecaa1b to 3237958 Compare December 5, 2024 13:16
@lmuntaner lmuntaner force-pushed the lm-add-well-known-ROR-standard branch from 060d2c9 to f485484 Compare December 5, 2024 13:41
@lmuntaner lmuntaner marked this pull request as ready for review December 5, 2024 13:48
@lmuntaner lmuntaner requested a review from sea-snake December 5, 2024 13:49
@lmuntaner
Copy link
Collaborator Author

@sea-snake ready for another review

Copy link
Contributor

@sea-snake sea-snake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lmuntaner lmuntaner added this pull request to the merge queue Dec 6, 2024
Merged via the queue into main with commit 4118aae Dec 6, 2024
67 checks passed
@lmuntaner lmuntaner deleted the lm-add-well-known-ROR-standard branch December 6, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants