Implement OpenID add/remove accounts in identity management #2762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/frontend/src/utils/iiConnection.ts # src/frontend/src/utils/mockOpenID.ts
sea-snake
commented
Dec 31, 2024
lmuntaner
reviewed
Jan 1, 2025
| @@ -433,7 +433,7 @@ xr-spatial-tracking=()", | |||
| let rgx = Regex::new( | |||
| "^default-src 'none';\ | |||
| connect-src 'self' https:;\ | |||
| img-src 'self' data:;\ | |||
| img-src 'self' data: https://\\*.googleusercontent.com;\ | |||
There was a problem hiding this comment.
Is this to be able to show the image from the google account?
There was a problem hiding this comment.
Yes exactly, currently the CSP only allowed images from it's own canister and data uris. I considered fetching the image and storing it as datauri instead but that would add quite some complexity and prevent it from showing the latest image if the user changes their profile image.
There was a problem hiding this comment.
Yes, this is fine. Maybe check with security by sending them a message, but it't not blocking this PR.
lmuntaner
reviewed
Jan 2, 2025
lmuntaner
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement OpenID add/remove accounts in identity management
Changes
OPENID_AUTHENTICATIONfeature flagII_OPENID_GOOGLE_CLIENT_IDenvironment variablehasOtherAuthMethodsto allow removal of all passkeys/credentials if one still has credentials/keys., since a user only needs to have at least 1 passkey or linked account.🟢 Some screens were added
🟡 Some screens were changed